refactor(diagnostic plugin)

[dpa99c]

update camera API function signatures to support cordova.plugins.diagnostic@3.6.0. See dpa99c/cordova-diagnostic-plugin@515317e

[ihadeed]

@dpa99c

Thanks for the PR!

TLDR: It just needs one quick change, we need to specify successIndex and errorIndex in the @Cordova() decorator as follows:

@Cordova({
  successIndex: 1,
  errorIndex: 2
})

Detailed explanation:

When there is an optional parameter, we need to add successIndex and errorIndex properties to the @Cordova() decorator. The decorator can't tell what the signature of the method is, it just takes the arguments passed to the function and passes them to the original method.

For example:

// if we call isCameraAvailable without explicitly providing value for externalStorage
this.diagnostics.isCameraAvailable();

// it will result in the original method being invoked like this
cordova.plugins.diagnostic.isCameraAvailable(onSuccess, onError);

So we need to specify our success and error index in the decorator as follows to fix this issue:

@Cordova({
  successIndex: 1,
  errorIndex: 0
})

Now the original method will be invoked with the following arguments if we use the same example above:

cordova.plugins.diagnostic.isCameraAvailable(undefined, onSuccess, onError);