fix(secure-storage): reject when the plugin doesn't exist

[eboukamza]

The create() method reject the promise when the plugin is not available for avoid return a never fulfilled promise when we call the methods of SecureStorageObject

Closes #1515

[ihadeed]

This behavior is intentional for plugins that create an instance of another object. In this situation the promise should ideally reject but in other cases like Google Maps it's better to create an instance object that doesn't do anything. Here's an example of why this is ideal:

let map: GoogleMap = this.googleMaps.create(...);

// the browser will throw an error because map.on doesn't exist
map.on('MAP_READY')
  .then(() => { ... });

I will review these plugins again and implement a universal fix. Maybe the plugins that return a promise (like this one) should reject, and the rest of them can return a dummy object.

[ptitjes]

@ihadeed The problem is that the user cannot see any difference between a dummy object and a real object. So the promise should resolve to null or be rejected.

For instance, you can't do things like the following because the navigation will never be set :

    this.platform.ready()
      .then(() => this.secureStorage.create(SECURE_STORAGE_NAME))
      .then(storage => storage ? storage.get(SECURE_STORAGE_KEY) : null)
      .then(credentials => credentials ? this.auth.login(credentials) : false)
      .then(granted => granted ? this.nav.setRoot(MainPage) : this.nav.setRoot(LoginPage))
      .catch(error => this.nav.setRoot(LoginPage))

Would you mind to accept the patch from @eboukamza, please ?

[eboukamza]

@ihadeed
I agree that is a quick fix but in my case this helps to turn my app in dev mode (browser).

If you want to work in a more elegant solution I can help you too.

[ihadeed]

Replace this block of code with: Never mind this comment, read the next comment below

const availabilityCheck: any = checkAvailability(SecureStorage.getPluginRef(), null, SecureStorage.getPluginName());
if (availabilityCheck === true) {
  const instance = new cordova.plugins.SecureStorage(...); // same code as above
} else {
  rej(availabilityCheck.error);
}

[ihadeed]

Sorry forget about the comment above, here's a better way to do it:

@CordovaCheck()
create(): Promise<SecureStorageObject> {
  return new Promise<SecureStorageObject>((resolve: Function) => {
    const instance = new cordova.plugins.SecureStorage(...);
  });
}

The @CordovaCheck() decorator will make it only run if the checkAvailability passes, and it will automatically reject with the error if it exists.

[eboukamza]

@ihadeed you are a unsolved conflict with the commit dfd0514 in the merge 7d63e80

[ihadeed]

@eboukamza thanks I fixed it and published a new release now. I didn't notice that until I tried building the plugin.