Add Base64 plugin #1645
Merged
Add Base64 plugin #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsogl
requested changes
Jun 3, 2017
| /** | ||
| * This function encodes base64 of any file | ||
| * | ||
| * @param {filePath} Absolute file path |
There was a problem hiding this comment.
Change this line to @param filePath {string} Absolute file path
| plugin: 'com-badrit-base64', | ||
| pluginRef: 'window.plugins.Base64', | ||
| repo: 'https://github.com/hazemhagrass/phonegap-base64', | ||
| install: 'ionic cordova plugin add com-badrit-base64', |
ihadeed
requested changes
Jun 3, 2017
| plugin: 'com-badrit-base64', | ||
| pluginRef: 'window.plugins.Base64', | ||
| repo: 'https://github.com/hazemhagrass/phonegap-base64', | ||
| install: 'ionic cordova plugin add com-badrit-base64', |
There was a problem hiding this comment.
This install line is not needed since the plugin doesn't require any variables.
| @Plugin({ | ||
| pluginName: 'Base64', | ||
| plugin: 'com-badrit-base64', | ||
| pluginRef: 'window.plugins.Base64', |
There was a problem hiding this comment.
no need to have window. here... plugins.Base64 is sufficient
| /** | ||
| * This function encodes base64 of any file | ||
| * | ||
| * @param {filePath} Absolute file path |
There was a problem hiding this comment.
This line should read:
* @param {string} filePath Absolute file path
|
|
||
| /** | ||
| * This function encodes base64 of any file | ||
| * |
There was a problem hiding this comment.
Remove blank JSDoc line here
danielsogl
approved these changes
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.