Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Plugin: Add clearAllNotifications method and return promises/observables #250

Closed
FdezRomero opened this issue Jun 27, 2016 · 4 comments

Comments

@FdezRomero
Copy link
Contributor

Hey there!

I started using the Push plugin and noticed that is missing the newer clearAllNotifications method.

I also noticed that the ionic-native wrapper is using the plugin's success and error callbacks instead of returning a promise/observable as it happens with most of the other plugins, which is confusing considering the docs say plugins return either of these.

Any chance to add this missing method and use promises/observables instead of callbacks? I'm guessing there are people already using this plugin so it should keep supporting the callbacks and return a promise/observable if none is specified.

Thanks!

@ihadeed
Copy link
Collaborator

ihadeed commented Jun 29, 2016

Hey,

Thanks for pointing it out.

We will have to rewrite the Push plugin using the @CordovaInstance wrapper in order to achieve that functionality. I guess we can add that to the road map (no set date, though).

@FdezRomero
Copy link
Contributor Author

Thanks @ihadeed! Looking forward to it as many apps use this plugin.

ihadeed added a commit that referenced this issue Aug 15, 2016
@FdezRomero
Copy link
Contributor Author

Hi @ihadeed!

Any news on adding the missing push.clearAllNotifications() method to the Push plugin?

Thanks!

@FdezRomero
Copy link
Contributor Author

Thanks @ihadeed! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants