Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Sharing plugin has incorrect return values #275

Closed
rtomchinsky opened this issue Jul 7, 2016 · 1 comment
Closed

Social Sharing plugin has incorrect return values #275

rtomchinsky opened this issue Jul 7, 2016 · 1 comment

Comments

@rtomchinsky
Copy link

rtomchinsky commented Jul 7, 2016 •
edited
Loading

The SocialSharing class has void return type for share and shareViaTwitter, instead of the expected Promise<any>, which breaks code using TypeScript. Is there a reason for this or is it a bug?

https://github.com/driftyco/ionic-native/blob/master/src/plugins/socialsharing.ts#L34
https://github.com/driftyco/ionic-native/blob/master/src/plugins/socialsharing.ts#L64
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 11, 2016

thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtomchinsky @ihadeed