Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sim plugin #317

Merged
merged 2 commits into from
Jul 17, 2016
Merged

Add sim plugin #317

merged 2 commits into from
Jul 17, 2016

Conversation

biesbjerg
Copy link
Contributor

@biesbjerg biesbjerg commented Jul 17, 2016 •
edited by ihadeed

Closes #306

ihadeed
ihadeed reviewed Jul 17, 2016
View reviewed changes
src/plugins/sim.ts
*/
@Plugin({
plugin: 'cordova-plugin-sim',
pluginRef: 'window.plugins.sim',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be only plugins.sim

Ionic native automatically adds window.

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 17, 2016

Looks good to me! Just edit the pluginRef and it will be perfect!

Thanks for the PR @biesbjerg

@biesbjerg
Copy link
Contributor Author

Done!

@ihadeed ihadeed merged commit 4f85110 into danielsogl:master Jul 17, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 17, 2016

Thanks again @biesbjerg

@specchiasoft specchiasoft mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@biesbjerg @ihadeed