Add Secure Storage #347
Merged
Add Secure Storage #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param storage {string} | ||
| */ | ||
| constructor(storage: string) { | ||
| let res, rej |
|
Read the comments. Also I think we should follow what Max did with the SQLite plugin here: f1c8ce3 This way we can keep the ionic-native modifications consistent. The usage would be something like: let secureStorage: SecureStorage = new SecureStorage();
secureStorage.create(<options>).then(<onSuccess>).catch(<onError>); |
…c-native plugins. Edited comments to reflect changes.
|
|
||
| // Properties | ||
| private _objectInstance: any; | ||
| init: Promise<any>; |
|
Looks good @begriffin |
|
I'm thinking the What do you guys think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin for https://github.com/Crypho/cordova-plugin-secure-storage