Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(camera-preview): Changes implementation to match Cordova plugin #441

Merged
merged 10 commits into from
Aug 19, 2016

Conversation

amuramoto
Copy link
Contributor

  • Changes interfaces to match plugin
  • Minor docs updates
  • Changes startCamera() function signature to match plugin

@ihadeed
Copy link
Collaborator

ihadeed commented Aug 17, 2016

Thanks Alex

We keep a prefix for the interface name to make sure that there are no conflicts in the future (in case another plugin uses the same name for their interfaces).

@amuramoto
Copy link
Contributor Author

No problem. I've prefixed the Size and Rect interfaces

@ihadeed ihadeed merged commit 55ba65a into danielsogl:master Aug 19, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Aug 19, 2016

thanks @amuramoto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants