Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VideoEditor): add video editor plugin. #457

Merged
merged 1 commit into from
Aug 19, 2016
Merged

feat(VideoEditor): add video editor plugin. #457

merged 1 commit into from
Aug 19, 2016

Conversation

mattlewis92
Copy link
Contributor

Closes #316

ihadeed
ihadeed reviewed Aug 19, 2016
View reviewed changes
src/plugins/video-editor.ts
};

public static OutputFileType = {
M4V: 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public is not needed as it is the default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed! 😄

@mattlewis92 mattlewis92 force-pushed the feat-plugin-video-editor branch from 0d3634e to d700645 Compare August 19, 2016 11:03
@ihadeed
Copy link
Collaborator

ihadeed commented Aug 19, 2016

Thanks @mattlewis92

@ihadeed ihadeed merged commit 7a53013 into danielsogl:master Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattlewis92 @ihadeed