Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File plugin createDir function replace parameter #516

Closed
xmellado opened this issue Aug 31, 2016 · 1 comment
Closed

File plugin createDir function replace parameter #516

xmellado opened this issue Aug 31, 2016 · 1 comment

Comments

@xmellado
Copy link

xmellado commented Aug 31, 2016

Hi!
The replace parameter in createDir(path, dirName, replace) function inside the file plugin is not properly implemented. It should be negated. Currently, when replace is true, if the directory exists, an error is thrown. When replace is false, if the directory exists, it is replaced. The behaviour should be opposite.

It is the same fix applied to the function createFile() in commit 14e41a3.

Best regards,
Xavi

@ihadeed
Copy link
Collaborator

ihadeed commented Sep 7, 2016

thanks

@ihadeed ihadeed closed this as completed in 7910493 Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants