Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements socialsharing #520

Merged
merged 8 commits into from
Sep 7, 2016

Conversation

ramonornela
Copy link
Contributor

  • Improvements docs;
  • Fix order callback because params are optional;
  • Feature add method shareVia();
  • Feature add params optionals canShareVia().

@guillenotfound
Copy link
Contributor

Hey! Thanks for this PR, have you been able to remove the delays while sharing? I'm actually using socialsharing without the wrapper...

@ramonornela
Copy link
Contributor Author

@ZiFFeL1992 continue delay, attempt try work it later ;), thanks by report.

@ihadeed
Copy link
Collaborator

ihadeed commented Sep 7, 2016

@ZiFFeL1992 I'm experiencing delays too, but they occur while using the original plugin API as well. It usually happens the first time the user tries to share something after launching the app.

@ihadeed
Copy link
Collaborator

ihadeed commented Sep 7, 2016

thanks for the PR @ramonornela

@ihadeed ihadeed merged commit 4f97164 into danielsogl:master Sep 7, 2016
@ramonornela
Copy link
Contributor Author

@ihadeed Sorry missing comma in the key errorIndex ;), i should have run npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants