Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with typepings for googlemaps #547

Closed
danielgek opened this issue Sep 13, 2016 · 3 comments
Closed

Issue with typepings for googlemaps #547

danielgek opened this issue Sep 13, 2016 · 3 comments

Comments

@danielgek
Copy link
Contributor

Hello, today i was using googlemaps plugin and i was trying to move camera using GoogleMapsLatLngBounds as target, because i want the camera to zoom accordingly with the array of points i have set, but as i'm using typescript, the current typings only accept GoogleMapsLatLng.

changing the typing from this:

export interface CameraPosition {
    target?: GoogleMapsLatLng;
    zoom?: number;
    tilt?: number;
    bearing?: number;
}

to:

export interface CameraPosition {
    target?: GoogleMapsLatLng | GoogleMapsLatLngBounds;
    zoom?: number;
    tilt?: number;
    bearing?: number;
}

fix the issue

@ihadeed
Copy link
Collaborator

ihadeed commented Sep 13, 2016

thanks

@danielgek
Copy link
Contributor Author

danielgek commented Sep 13, 2016

wow that was fast !! thank you

@danielgek
Copy link
Contributor Author

@ihadeed you should add GoogleMapsLatLng[] too, sorry for not mention early! i just noticed in the documentation and i don't have sure but animateCamera may need it too.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants