ionic-native@2.2.4 - SQLite transaction success part is undefined.

[NeoLSN]

SQLite transaction will not resolve or reject after tx.executeSql.
It just stock in there.

let queries = ['...', '...'];
this._db.transaction((tx) => {
    queries.forEach((query) => {
        tx.executeSql(query, []);
    });
})
    .then(() => {
        console.log('Transaction done');
    }, (error) => {
        console.log('Transaction error: ', error);
    });

No Transaction done' or 'Transaction error: ' will be logged.

2.2.3 works fine just needs to change resolve/reject function order.

[ihadeed]

Your usage is incorrect.

this._db.transaction().then(tx => tx.executeSql(...)).then(result => ...);

On Oct 19, 2016 12:14 PM, "NeoLSN" notifications@github.com wrote:

SQLite transaction will not resolve or reject after tx.executeSql.
It just stock in there.

let queries = ['...', '...'];
this._db.transaction((tx) => {
queries.forEach((query) => {
tx.executeSql(query, []);
});
})
.then(() => {
console.log('Transaction done');
}, (error) => {
console.log('Transaction error: ', error);
});

No Transaction done' or 'Transaction error: ' will be logged.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#732, or mute the thread
https://github.com/notifications/unsubscribe-auth/ANJ8dNLOUKbSI1u6qtZsgOv_9t-wAPepks5q1kHdgaJpZM4KbK1c
.

[NeoLSN]

@ihadeed
I tried your way, but it is still not working.
There is no resolve/reject part will be called.
So I couldn't get any tx.

[NeoLSN]

ionic-native@2.2.4, the tx

tx =>  
SQLitePluginTransaction
db: SQLitePlugin
error: function (e){s(t,n,e)}
executes: Array[0]
finalized: true
fn: function (e){t.forEach(function(t){e.executeSql(t,[],function(t,e){console.log("tx => ",t)},function(t){console.log("error => ",t)})})}
readOnly: false
success: undefined
txlock: true
__proto__: SQLitePluginTransaction

ionic-native@2.2.3, the tx

tx =>
SQLitePluginTransaction
db: SQLitePlugin
error: function (e){s(t,n,e)}
executes: Array[0]
finalized: true
fn: function (e){t.forEach(function(t){e.executeSql(t,[],function(t,e){console.log("tx => ",t)},function(t){console.log("error => ",t)})})}
readOnly: false
success: function (e){s(t,n,e)}
txlock: true
__proto__: SQLitePluginTransaction

The different thing is the success part on ionic-native@2.2.4 is 'undefined'.
Could you make some time to check it?

[ihadeed]

Sorry, never mind my previous reply, got things mixed up. Your usage is correct.

Just had a look at what's going on. The issue is happening here https://github.com/driftyco/ionic-native/blob/master/src/plugins/plugin.ts#L70-L81

// Line 69
args = [fn];

// Line 70 
// successIndex ( 2 ) is greater than args.length (1)
// Line 71
args = [fn, undefined, resolve];

// Line 77
// errorIndex (1) is less than args.length (3)
// Line 80
args = [fn, reject, undefined, resolve];

// Which leads to 
db.transaction(fn, reject, undefined, resolve);

I'll fix this soon.