feat(rollbar): Add Rollbar plugin #832
Conversation
| * @return {Promise<any>} Returns a promise that resolves when the plugin successfully initializes | ||
| */ | ||
| @Cordova() | ||
| static init(successCallback?: Function, errorCallback?: Function) { |
There was a problem hiding this comment.
Can you add a return type : Promise<any> to this function. Also keep { return; } all in the same line.
Thanks.
There was a problem hiding this comment.
@ihadeed sure. I documented this function as returning Promise<any> because, as far as I know, ionic-native wraps every function in a promise. The plugin function itself doesn't return anything. Is this the right approach or should I document it as returning void?
There was a problem hiding this comment.
Here is an example of how it should look like: https://github.com/driftyco/ionic-native/blob/master/src/plugins/camera.ts#L201
The docs are fine, just need to add a TypeScript return type of Promise<any>.
| * @return {Promise<any>} Returns a promise that resolves when the plugin successfully initializes | ||
| */ | ||
| @Cordova() | ||
| static init(successCallback?: Function, errorCallback?: Function): Promise<any> { return; } |
There was a problem hiding this comment.
You also need to remove successCallback?: Function, errorCallback?: Function. The @Cordova() decorator will automatically apply resolve and reject of the promise to these arguments.
Sorry I didn't mention this earlier.
There was a problem hiding this comment.
No problem, removed it.
No description provided.