Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native SMS.send().then()..catch() promise throws error #858

Closed
mhartington opened this issue Dec 9, 2016 · 2 comments
Closed

Native SMS.send().then()..catch() promise throws error #858

mhartington opened this issue Dec 9, 2016 · 2 comments

Comments

@mhartington
Copy link
Contributor

From @barocsi on December 9, 2016 16:44

Ionic version: (check one with "x")
[ ] 1.x
[ x] 2.x

I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
Native SMS.send() falls into error after sms is sent.

SMS.send(a,b)
      .then(() => {
        // should be active
      })
      .catch((error: any) => {
          // THIS IS ACTIVE, error echoes "OK"
          })
        }
      );

Expected behavior:
code above

Steps to reproduce:
code above

Copied from original issue: ionic-team/ionic-framework#9572

@ihadeed
Copy link
Collaborator

ihadeed commented Dec 11, 2016

@barocsi This occurs when the options param is omitted. Just fixed it and it will be available in next patch release. For now you can just pass null or {} as a third param to work around this issue.

@barocsi
Copy link

barocsi commented Dec 11, 2016

Thanks! That will do for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants