Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LaunchReview #949

Merged
merged 2 commits into from
Jan 20, 2017
Merged

Add LaunchReview #949

merged 2 commits into from
Jan 20, 2017

Conversation

biesbjerg
Copy link
Contributor

No description provided.

@biesbjerg
Copy link
Contributor Author

When running ionic serve / cordova is not available, and I access plugin method using ionic native plugin wrapper without a catch(), I get an error:

LaunchReview.launch(appId)
	.then(() => {
		console.log("Successfully launched store app");
	});
EXCEPTION: Uncaught (in promise): cordova_not_available

Is that expected or is the promise suppose to reject instead?

@ihadeed
Copy link
Collaborator

ihadeed commented Jan 9, 2017

@biesbjerg that's normal, Angular 2 lets you know if you didn't handle promise rejections. The promise does reject when you're running on serve.

Btw, how is this plugin different than the App Rate plugin?

@biesbjerg
Copy link
Contributor Author

This plugin is used for launching the App Store / Google Play (and on iOS it switches to the Review tab).
It doesn't contain logic for prompting etc.

@ihadeed
Copy link
Collaborator

ihadeed commented Jan 9, 2017

@biesbjerg ok sounds good. I will merge this for the next non-patch release.

@ihadeed ihadeed added this to the v2.3.0 milestone Jan 10, 2017
@biesbjerg
Copy link
Contributor Author

@biesbjerg that's normal, Angular 2 lets you know if you didn't handle promise rejections. The promise does reject when you're running on serve.

The reason I'm asking is because when I access other plugins (some, not all) I get a warning in console instead of an uncaught exception:

image

Shouldn't it be handled the same?

(Ping @ihadeed - not sure you're notified of this message otherwise)

@ihadeed
Copy link
Collaborator

ihadeed commented Jan 11, 2017

@biesbjerg yeah I did a mistake a few days ago, it returns that console log when there is an uncaught exception. In v2.2.16 it's fully fixed and it should only show that message when the plugin isn't installed/available.

@ihadeed ihadeed merged commit 9c75a06 into danielsogl:master Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants