Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-maps): Adds some functions of BaseClass #993

Merged
merged 1 commit into from
Jan 22, 2017
Merged

fix(google-maps): Adds some functions of BaseClass #993

merged 1 commit into from
Jan 22, 2017

Conversation

guillenotfound
Copy link
Contributor

References: #819

Missing functions yet:

  • removeEventListener()
  • off()
  • trigger()

@ihadeed
Copy link
Collaborator

ihadeed commented Jan 22, 2017

Thanks. I'll merge this for now for the sake of covering all the plugin's functionality. But in the future it would be nice to have a base class that all the other classes extend. I still need to do some experimenting to see how this would work with the decorators we have.

@ihadeed ihadeed merged commit 9f98f8e into danielsogl:master Jan 22, 2017
@hartherbert
Copy link
Contributor

Does anyone have interest in implementing the missing functions of the BaseClass?

removeEventListener()
off()
trigger()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants