Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in CordovaProperty #998

Merged
merged 1 commit into from
Jan 22, 2017
Merged

Conversation

peterkelly
Copy link
Contributor

This reverts part of commit 67adb23, which moved the call to getPlugin()
from within CordovaProperty() to a point where it was called too early.

When the CordovaProperty decorator is called on a property, the class
containing that call has not yet had its Plugin decorator called. Only
when the latter happens does pluginRef get set. Thus, attempting to
access pluginRef within CordovaProperty at the time of the call will
give undefined, and attemping to call getPlugin with an undefined value
will throw an exception:

Runtime Error
Cannot read property 'split' of undefined

TypeError: Cannot read property 'split' of undefined
    at get
    at getPlugin
    at CordovaProperty
    at __decorate
    ...

The above message can be seen in the browser after running the 'ionic
serve' command.

This commit moves the getPlugin call back to the getters and setters
established by CordovaProperty, which are only called after the Plugin
decorator has finished executing.

closes #992

This reverts part of commit 67adb23, which moved the call to getPlugin()
from within CordovaProperty() to a point where it was called too early.

When the CordovaProperty decorator is called on a property, the class
containing that call has not yet had its Plugin decorator called. Only
when the latter happens does pluginRef get set. Thus, attempting to
access pluginRef within CordovaProperty at the time of the call will
give undefined, and attemping to call getPlugin with an undefined value
will throw an exception:

    Runtime Error
    Cannot read property 'split' of undefined

    TypeError: Cannot read property 'split' of undefined
        at get
        at getPlugin
        at CordovaProperty
        at __decorate
        ...

The above message can be seen in the browser after running the 'ionic
serve' command.

This commit moves the getPlugin call back to the getters and setters
established by CordovaProperty, which are only called *after* the Plugin
decorator has finished executing.

closes danielsogl#992
@ihadeed ihadeed merged commit cb29363 into danielsogl:master Jan 22, 2017
@ihadeed
Copy link
Collaborator

ihadeed commented Jan 22, 2017

Thanks

@Nelly204
Copy link

Hej, i've tried to build an App with cordova. First I install Cordova@7.0.1, (this version were installed automatically when i wrote "$ npm install -g cordova") than I create a new Project and add a plattform (andoird), but when I tried $ cordova build android> I got this Message: "Error: Cannot read property 'split' of undefined". Do you have any idea, how to fix it?
The version of Android sdk and Java jre are the current version

Thanks for answers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RunTime Error: Cannot read property 'split' of undefined
3 participants