fix(menu): ios styles

ionic-team · Sep 1, 2018 · 281f9a3 · 281f9a3
1 parent e741643
commit 281f9a3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 11 deletions.
diff --git a/core/src/components/menu/menu.ios.scss b/core/src/components/menu/menu.ios.scss
@@ -4,10 +4,6 @@
 // iOS Menu
 // --------------------------------------------------
 
-.menu-inner {
-  background: $menu-ios-background;
-}
-
 :host(.menu-type-overlay) .menu-inner {
   box-shadow: $menu-ios-box-shadow-overlay;
 }

diff --git a/core/src/components/menu/menu.md.scss b/core/src/components/menu/menu.md.scss
@@ -4,10 +4,6 @@
 // Material Design Menu
 // --------------------------------------------------
 
-.menu-inner {
-  background: $menu-md-background;
-}
-
 :host(.menu-type-overlay) .menu-inner {
   box-shadow: $menu-md-box-shadow;
 }
diff --git a/core/src/components/menu/menu.scss b/core/src/components/menu/menu.scss
@@ -6,6 +6,7 @@
 :host {
   --width: #{$menu-width};
   --width-small: #{$menu-small-width};
+  --background: #{$background-color};
 
   @include position(0, 0, 0, 0);
 
@@ -33,6 +34,8 @@
   width: var(--width);
   height: 100%;
 
+  background: var(--background);
+
   contain: strict;
 }
 

diff --git a/core/src/components/menu/menu.tsx b/core/src/components/menu/menu.tsx
@@ -60,8 +60,10 @@ export class Menu implements MenuI {
   @Watch('type')
   typeChanged(type: string, oldType: string | undefined) {
     const contentEl = this.contentEl;
-    if (contentEl && oldType) {
-      contentEl.classList.remove(`menu-content-${oldType}`);
+    if (contentEl) {
+      if (oldType) {
+        contentEl.classList.remove(`menu-content-${oldType}`);
+      }
       contentEl.classList.add(`menu-content-${type}`);
       contentEl.removeAttribute('style');
     }

diff --git a/core/src/components/picker/picker.tsx b/core/src/components/picker/picker.tsx
@@ -251,7 +251,8 @@ export class Picker implements OverlayInterface {
     return [
       <ion-backdrop
         visible={this.showBackdrop}
-        tappable={this.backdropDismiss}>
+        tappable={this.backdropDismiss}
+      >
       </ion-backdrop>,
 
       <div class="picker-wrapper" role="dialog">