Skip to content

Commit

Permalink
fix(item-sliding): use a white item background instead of transparent (
Browse files Browse the repository at this point in the history
…#16507)

- use the global item background variable for md
- lowers screenshot threshold to catch this regression

fixes #16474
  • Loading branch information
brandyscarney authored Nov 29, 2018
1 parent 5096503 commit 2d33c63
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion core/src/components/item/item.md.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

:host {
--min-height: #{$item-md-min-height};
--background: var(--ion-item-background, transparent);
--background: #{$item-md-background};
--background-activated: var(--background);
--border-color: #{$item-md-border-bottom-color};
--color: #{$item-md-color};
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/item/test/reorder/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
for (var i = 0; i < items.length; i++) {
groupEl.innerHTML += `
<ion-item onClick="clickedButton(${i})"
style="min-height: ${i * 2 + 35}px; background-color: rgb(${255 - i * 4}, ${255 - i * 4}, ${255 - i * 4})">
style="min-height: ${i * 2 + 35}px; --background: rgb(${255 - i * 4}, ${255 - i * 4}, ${255 - i * 4})">
${i}
<ion-reorder slot="end"></ion-reorder>
</ion-item>`;
Expand Down
2 changes: 1 addition & 1 deletion core/stencil.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export const config: Config = {
],
testing: {
allowableMismatchedPixels: 200,
pixelmatchThreshold: 0.1,
pixelmatchThreshold: 0.05,
emulate: [
{
userAgent: 'iPhone',
Expand Down

0 comments on commit 2d33c63

Please sign in to comment.