fix(tabs): name prop is not longer used

ionic-team · Oct 31, 2018 · 6d11cc1 · 6d11cc1
1 parent 0faa355
commit 6d11cc1
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 22 deletions.
diff --git a/angular/src/directives/proxies.ts b/angular/src/directives/proxies.ts
@@ -891,7 +891,7 @@ export class TabButton {
 }
 
 export declare interface Tabs extends StencilComponents<'IonTabs'> {}
-@Component({ selector: 'ion-tabs', changeDetection: ChangeDetectionStrategy.OnPush, encapsulation: ViewEncapsulation.None, template: '<ng-content></ng-content>', inputs: ['name'] })
+@Component({ selector: 'ion-tabs', changeDetection: ChangeDetectionStrategy.OnPush, encapsulation: ViewEncapsulation.None, template: '<ng-content></ng-content>' })
 export class Tabs {
   ionChange: EventEmitter<CustomEvent>;
   ionNavWillLoad: EventEmitter<CustomEvent>;
@@ -902,7 +902,6 @@ export class Tabs {
     c.detach();
     const el = r.nativeElement;
     proxyMethods(this, el, ['select', 'setRouteId', 'getRouteId', 'getTab', 'getSelected']);
-    proxyInputs(this, el, ['name']);
     proxyOutputs(this, el, ['ionChange', 'ionNavWillLoad', 'ionNavWillChange', 'ionNavDidChange']);
   }
 }

diff --git a/core/src/components.d.ts b/core/src/components.d.ts
@@ -4586,20 +4586,12 @@ export namespace Components {
     */
     'getTab': (tab: string | HTMLIonTabElement) => Promise<HTMLIonTabElement | undefined>;
     /**
-    * A unique name for the tabs.
-    */
-    'name'?: string;
-    /**
     * Index or the Tab instance, of the tab to select.
     */
     'select': (tab: string | HTMLIonTabElement) => Promise<boolean>;
     'setRouteId': (id: string) => Promise<RouteWrite>;
   }
   interface IonTabsAttributes extends StencilHTMLAttributes {
-    /**
-    * A unique name for the tabs.
-    */
-    'name'?: string;
     /**
     * Emitted when the tab changes.
     */

diff --git a/core/src/components/tabs/readme.md b/core/src/components/tabs/readme.md
@@ -33,13 +33,6 @@ direct children of `ion-tabs`, like this:
 <!-- Auto Generated Below -->
 
 
-## Properties
-
-| Property | Attribute | Description                 | Type                  |
-| -------- | --------- | --------------------------- | --------------------- |
-| `name`   | `name`    | A unique name for the tabs. | `string \| undefined` |
-
-
 ## Events
 
 | Event              | Detail                   | Description                                                                |

diff --git a/core/src/components/tabs/tabs.tsx b/core/src/components/tabs/tabs.tsx
@@ -21,11 +21,6 @@ export class Tabs implements NavOutlet {
   @Prop({ context: 'config' }) config!: Config;
   @Prop({ context: 'document' }) doc!: Document;
 
-  /**
-   * A unique name for the tabs.
-   */
-  @Prop() name?: string;
-
   /**
    * Emitted when the tab changes.
    */