fix(nav): animation backdrop

ionic-team · Aug 7, 2018 · 948d083 · 948d083
1 parent 48e2a4e
commit 948d083
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 18 deletions.
diff --git a/core/src/components.d.ts b/core/src/components.d.ts
@@ -1486,7 +1486,6 @@ declare global {
        * Returns the length of navigation stack
        */
       'isAnimating': () => boolean;
-      'length': () => number;
       /**
        * Call to navigate back from a current component. Similar to push(), you can also pass navigation options.
        */

diff --git a/core/src/components/animation-controller/animation-interface.tsx b/core/src/components/animation-controller/animation-interface.tsx
@@ -23,7 +23,6 @@ export interface Animation {
   beforeClearStyles(propertyNames: string[]): Animation;
   beforeAddRead(domReadFn: () => void): Animation;
   beforeAddWrite(domWriteFn: () => void): Animation;
-  duringAddClass(className: string): Animation;
   afterAddClass(className: string): Animation;
   afterRemoveClass(className: string): Animation;
   afterStyles(styles: { [property: string]: any; }): Animation;

diff --git a/core/src/components/animation-controller/animator.tsx b/core/src/components/animation-controller/animator.tsx
@@ -248,15 +248,6 @@ export class Animator {
     return this;
   }
 
-  /**
-   * Sets a CSS class during the duration of the animation.
-   */
-  duringAddClass(className: string): Animator {
-    this.beforeAddClass(className);
-    this.afterRemoveClass(className);
-    return this;
-  }
-
   /**
    * Set CSS inline styles to this animation's elements
    * before the animation begins.
@@ -817,6 +808,7 @@ export class Animator {
       const elementClassList = el.classList;
 
       // css classes to add before the animation
+
       if (addClasses) {
         for (const c of addClasses) {
           // ******** DOM WRITE ****************

diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx
@@ -484,7 +484,6 @@ export class Datetime {
   private updateText() {
     // create the text of the formatted data
     const template = this.displayFormat || this.pickerFormat || DEFAULT_FORMAT;
-    // debugger;
     this.text = renderDatetime(template, this.datetimeValue, this.locale);
   }
 

diff --git a/core/src/components/nav/nav.tsx b/core/src/components/nav/nav.tsx
@@ -441,11 +441,6 @@ export class Nav implements NavOutlet {
     return this.isTransitioning;
   }
 
-  @Method()
-  length() {
-    return this.views.length;
-  }
-
   // _queueTrns() adds a navigation stack change to the queue and schedules it to run:
   // 1. _nextTrns(): consumes the next transition in the queue
   // 2. _viewInit(): initializes enteringView if required

diff --git a/core/src/utils/animations/ios.transition.ts b/core/src/utils/animations/ios.transition.ts
@@ -33,7 +33,7 @@ export function iosTransitionAnimation(AnimationC: Animation, navEl: HTMLElement
     const navDecor = new AnimationC();
     navDecor
       .addElement(navEl)
-      .duringAddClass('show-decor');
+      .beforeAddClass('show-decor');
 
     rootTransition.add(navDecor);
   }