fix(menu): do not override --ion-color-base

ionic-team · Aug 24, 2018 · a890828 · a890828
1 parent 5f90dbf
commit a890828
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/core/src/components/menu-button/menu-button.ios.scss b/core/src/components/menu-button/menu-button.ios.scss
@@ -5,7 +5,7 @@
 // --------------------------------------------------
 
 :host {
-  --ion-color-base: #{ion-color(primary, base)};
+  color: #{ion-color(primary, base)};
 }
 
 button {

diff --git a/core/src/components/menu-button/menu-button.md.scss b/core/src/components/menu-button/menu-button.md.scss
@@ -4,10 +4,6 @@
 // MD Menu Button
 // --------------------------------------------------
 
-:host {
-  --ion-color-base: currentColor;
-}
-
 button {
   @include padding(0, 8px);
 }

diff --git a/core/src/components/menu-button/menu-button.scss b/core/src/components/menu-button/menu-button.scss
@@ -6,8 +6,6 @@
 :host {
   pointer-events: all;
 
-  color: #{current-color(base)};
-
   text-align: center;
   text-decoration: none;
   text-overflow: ellipsis;

diff --git a/core/src/components/select/select.tsx b/core/src/components/select/select.tsx
@@ -257,11 +257,11 @@ export class Select {
   }
 
   @Method()
-  open(ev?: UIEvent): Promise<HTMLIonActionSheetElement | HTMLIonAlertElement | HTMLIonPopoverElement>{
+  open(ev?: UIEvent): Promise<HTMLIonActionSheetElement | HTMLIonAlertElement | HTMLIonPopoverElement> {
     let selectInterface = this.interface;
 
     if ((selectInterface === 'action-sheet' || selectInterface === 'popover') && this.multiple) {
-      console.warn('Select interface cannot be "' + selectInterface + '" with a multi-value select. Using the "alert" interface instead.');
+      console.warn(`Select interface cannot be "${selectInterface}" with a multi-value select. Using the "alert" interface instead.`);
       selectInterface = 'alert';
     }