Skip to content

Commit

Permalink
fix(label): using prop for position
Browse files Browse the repository at this point in the history
also fixes #14288
  • Loading branch information
manucorporat committed Apr 13, 2018
1 parent 641113f commit b1ee4b8
Show file tree
Hide file tree
Showing 22 changed files with 327 additions and 259 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
<ion-content padding>
<ion-list>
<ion-item>
<ion-label floating>First Name</ion-label>
<ion-label position="floating">First Name</ion-label>
<ion-input name="firstName" #viewFirstName="ngModel" [(ngModel)]="firstName" required minlength="2"></ion-input>
</ion-item>
<ion-text *ngIf="viewFirstName.invalid && (viewFirstName.dirty || viewFirstName.touched)" color="danger">
<small *ngIf="viewFirstName.errors['required']">First Name is required</small>
<small *ngIf="viewFirstName.errors['minlength']">First Name must be at least 2 characters long</small>
</ion-text>
<ion-item>
<ion-label floating>Last Name</ion-label>
<ion-label position="floating">Last Name</ion-label>
<ion-input name="lastName" #viewLastName="ngModel" [(ngModel)]="lastName" required minlength="4"></ion-input>
</ion-item>
<ion-text *ngIf="viewLastName.invalid && (viewLastName.dirty || viewLastName.touched)" color="danger">
Expand Down Expand Up @@ -55,15 +55,15 @@
<ion-toggle name="feedEngineers" color="danger" [(ngModel)]="feedEngineers"></ion-toggle>
</ion-item>
<ion-item>
<ion-label floating>Short Self Description</ion-label>
<ion-label position="floating">Short Self Description</ion-label>
<ion-textarea name="selfDescription" #viewSelfDescription="ngModel" [(ngModel)]="selfDescription" required minlength="25"></ion-textarea>
</ion-item>
<ion-text *ngIf="viewSelfDescription.invalid && (viewSelfDescription.dirty || viewSelfDescription.touched)" color="danger">
<small *ngIf="viewSelfDescription.errors['required']">Self Description is required</small>
<small *ngIf="viewSelfDescription.errors['minlength']">Please tell us more</small>
</ion-text>
<ion-item>
<ion-label floating>Desired Salary</ion-label>
<ion-label position="floating">Desired Salary</ion-label>
<ion-input name="desiredSalary" #viewSalary="ngModel" type="number" required [(ngModel)]="desiredSalary"></ion-input>
</ion-item>
<ion-text *ngIf="viewSalary.invalid && (viewSalary.dirty || viewSalary.touched)" color="danger">
Expand Down
Loading

0 comments on commit b1ee4b8

Please sign in to comment.