fix(menu-button): fix sass linting

ionic-team · Jul 24, 2018 · d22f04b · d22f04b
1 parent ddb1e49
commit d22f04b
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 8 deletions.
diff --git a/core/src/components/alert/alert-interface.ts b/core/src/components/alert/alert-interface.ts
@@ -13,7 +13,7 @@ export interface AlertOptions {
 
 export interface AlertInput {
   type: string;
-  name: string | number;
+  name: string;
   placeholder?: string;
   value?: string;
   label?: string;

diff --git a/core/src/components/item-option/item-option.tsx b/core/src/components/item-option/item-option.tsx
@@ -60,6 +60,7 @@ export class ItemOption {
 
     return (
       <TagType
+        type="button"
         class="item-option-native"
         disabled={this.disabled}
         href={this.href}

diff --git a/core/src/components/item-options/item-options.tsx b/core/src/components/item-options/item-options.tsx
@@ -12,8 +12,7 @@ import { isEndSide } from '../../utils/helpers';
 export class ItemOptions {
   @Element() el!: HTMLElement;
 
-  @Prop({ context: 'window' })
-  win!: Window;
+  @Prop({ context: 'window' }) win!: Window;
 
   /**
    * The side the option button should be on. Possible values: `"start"` and `"end"`. Defaults to `"end"`. If you have multiple `ion-item-options`, a side must be provided for each.

diff --git a/core/src/components/menu-button/menu-button.ios.scss b/core/src/components/menu-button/menu-button.ios.scss
@@ -9,7 +9,7 @@
 }
 
 button {
-  padding: 0 5px;
+  @include padding(0, 5px);
 }
 
 ion-icon {

diff --git a/core/src/components/menu-button/menu-button.md.scss b/core/src/components/menu-button/menu-button.md.scss
@@ -9,7 +9,7 @@
 }
 
 button {
-  padding: 0 8px;
+  @include padding(0, 8px);
 }
 
 ion-icon {

diff --git a/core/src/components/menu-button/menu-button.scss b/core/src/components/menu-button/menu-button.scss
@@ -15,14 +15,16 @@ button {
   @include font-smoothing();
 
   display: flex;
-  height: 32px;
+
   position: relative;
 
   flex-flow: row nowrap;
   flex-shrink: 0;
   align-items: center;
   justify-content: center;
 
+  height: 32px;
+
   border: 0;
 
   outline: none;
@@ -47,7 +49,8 @@ button {
 }
 
 ion-icon {
-  padding: 0;
-  margin: 0;
+  @include margin(0);
+  @include padding(0);
+
   pointer-events: none;
 }