Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(content): set height to make it accessible for childs #14772

Merged
merged 1 commit into from
Jul 17, 2018
Merged

feat(content): set height to make it accessible for childs #14772

merged 1 commit into from
Jul 17, 2018

Conversation

tntwist
Copy link
Contributor

@tntwist tntwist commented Jul 13, 2018

Short description of what this resolves:

Makes height of content available for childs.

Changes proposed in this pull request:

  • add height: 100%; to scroll-inner class of content component.

Ionic Version: 4.x

Fixes: #14771

@brandyscarney brandyscarney self-assigned this Jul 17, 2018
@brandyscarney brandyscarney merged commit 857b42d into ionic-team:master Jul 17, 2018
@brandyscarney
Copy link
Member

Thank you for the PR!

@tntwist
Copy link
Contributor Author

tntwist commented Jul 17, 2018

Thanks for the fast response :) I really appreciate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tntwist @brandyscarney