Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix scrollAssist boolean instead of string definition #15203

Merged
merged 1 commit into from
Aug 17, 2018
Merged

fix: Fix scrollAssist boolean instead of string definition #15203

merged 1 commit into from
Aug 17, 2018

Conversation

peterpeterparker
Copy link
Contributor

Short description of what this resolves:

This resolves #15202 respectively it fix the definition of scrollAssist in config.ts by declaring it as boolean instead of string as introduced in v4.beta-3

Ionic Version:

v4

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Aug 16, 2018
@peterpeterparker peterpeterparker mentioned this pull request Aug 16, 2018
Closed
@manucorporat manucorporat merged commit 2af72fa into ionic-team:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@manucorporat manucorporat Awaiting requested review from manucorporat

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ionic v4-beta.3] scrollAssist should be declared as boolean
3 participants
@peterpeterparker @brandyscarney @manucorporat