Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.6] css Range does not properly fit #15393

Closed
goelectricstations opened this issue Aug 30, 2018 · 4 comments
Closed

[4.0.0-beta.6] css Range does not properly fit #15393

goelectricstations opened this issue Aug 30, 2018 · 4 comments
Assignees

Comments

@goelectricstations
Copy link

goelectricstations commented Aug 30, 2018

Ionic:

ionic (Ionic CLI) : 4.1.1 (C:\Users\Computer\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework : @ionic/angular 4.0.0-beta.6
@angular-devkit/core : 0.7.5
@angular-devkit/schematics : 0.7.5
@angular/cli : 6.1.5
@ionic/ng-toolkit : 1.0.0
@ionic/schematics-angular : 1.0.1

Cordova:

cordova (Cordova CLI) : 8.0.0
Cordova Platforms : android 7.1.0, ios 4.5.4
Cordova Plugins : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 1.2.1, (and 11 other plugins)

System:

NodeJS : v8.9.4 (C:\Program Files\nodejs\node.exe)
npm : 6.3.0-next.0
OS : Windows 10

Range does not properly fit
image

  <ion-item>
      <ion-range min="-200" max="200" color="secondary">
        <ion-label slot="start">-200</ion-label>
        <ion-label slot="end">200</ion-label>
      </ion-range>
    </ion-item>
@ionitron-bot ionitron-bot bot added the triage label Aug 30, 2018
@goelectricstations goelectricstations changed the title [4.0.0-beta.6] css range not correct [4.0.0-beta.6] css Range does not properly fit Aug 30, 2018
@mhartington
Copy link
Contributor

This looks to be an issue with the flex properties of the labels and range-slider. Will look into this.

@ionitron-bot ionitron-bot bot removed the triage label Aug 30, 2018
@goelectricstations
Copy link
Author

@mhartington

this fix the issue:

ion-range > ion-label {
flex: initial !important;
}

@brandyscarney
Copy link
Member

I've confirmed this issue still exists in latest. The following CSS is not being applied: https://github.com/ionic-team/ionic/blob/master/core/src/components/range/range.scss#L30-L32

I can fix this by moving the code to label, but I'm not sure if this is the right solution:

:host-context(ion-range.in-item) {
  flex: initial;
}

cc @manucorporat

@camwiegert camwiegert self-assigned this Nov 26, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 27, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants