fix(ion-datetime): keep the model value consistently an ISO string #15907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this, would be great to get this merged in an upcoming release! |
| @@ -356,7 +356,7 @@ export function convertDataToISO(data: DatetimeData): string { | |||
|
|
|||
| } else { | |||
| // YYYY-MM-DDTHH:mm:SS+/-HH:mm | |||
| rtn += (data.tzOffset > 0 ? '+' : '-') + twoDigit(Math.floor(data.tzOffset / 60)) + ':' + twoDigit(data.tzOffset % 60); | |||
| rtn += (data.tzOffset > 0 ? '+' : '-') + twoDigit(Math.floor(Math.abs(data.tzOffset / 60))) + ':' + twoDigit(data.tzOffset % 60); | |||
There was a problem hiding this comment.
what does this fix? do we need Math.floor() then? Math.round should return an integer already
There was a problem hiding this comment.
For negative numbers, -7.15 would floor() to -8, but we need it to be -7. See the 'appends a partial hour negative offset timezone' test. That would be -08:15 w/o this change but -435 minutes is -07:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Keep the
valueproperty consistently an ISO date string.NOTE: this is an alternate approach to PR #15833
Changes proposed in this pull request:
this.datetimeValueand is updated when thevalueproperty changes or when a new date is picked from the pickerIonic Version: 4.x
Fixes: #15408