Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: Review global CSS properties for v4 #15989

Closed
brandyscarney opened this issue Oct 17, 2018 · 2 comments
Closed

CSS: Review global CSS properties for v4 #15989

brandyscarney opened this issue Oct 17, 2018 · 2 comments
Assignees
@brandyscarney

Comments

@brandyscarney
Copy link
Member

Currently we have a load of CSS properties: https://beta.ionicframework.com/docs/theming/advanced#application-colors

Some of these are not even being used properly. For example, --ion-tabbar-text-color-active is used on md with a fallback to #488aff:

var(--ion-tabbar-text-color-active, #488aff)

However, ios uses just the primary color:

ion-color(primary, base)

I will review all of these variables to make sure they are first and foremost being used, and review the naming for consistency.
@brandyscarney brandyscarney self-assigned this Oct 17, 2018
@brandyscarney
Copy link
Member Author

This issue is related #15559 and will be solved as part of this

brandyscarney added a commit that referenced this issue Oct 17, 2018
@brandyscarney
test(themes): modify css-variables test to include more examples
fa701eb 
- Adds tabs to test their global variables
- Moves the related theme css files into its test folder
- Comments out the defaults in the defaults file because we need to
test out the fallbacks (leaving commented for now because I may want to
reference them)
- Adds an e2e file to get this test added to screenshot

references #15989
brandyscarney added a commit that referenced this issue Oct 18, 2018
@brandyscarney
fix(css): update global variables for consistent use
2c76fee 
- removes the non mode-specific global Sass variables
- updates the md and ios values so that the default is the css variable
with different fallbacks
- removes non-color related css variables from the global file
- fixes item so it uses the background color that is set by the global
file

references #15989
@brandyscarney brandyscarney mentioned this issue Oct 18, 2018
Merged
brandyscarney added a commit to ionic-team/ionic-docs that referenced this issue Oct 23, 2018
@brandyscarney
docs(theming): update the global css variables
67a78b7 
references ionic-team/ionic-framework#16003
references ionic-team/ionic-framework#15989
brandyscarney added a commit to ionic-team/ionic-docs that referenced this issue Oct 23, 2018
@brandyscarney
docs(theming): update the documented global css variables (#154)
18529ca 
references ionic-team/ionic-framework#16003
references ionic-team/ionic-framework#15989
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 22, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandyscarney