Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-bar): update to match MD design and remove transforms #16348

Merged
merged 24 commits into from
Nov 21, 2018

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Nov 16, 2018

Short description of what this resolves:

Updates the tab-bar to match the MD bottom navigation spec: https://material.io/design/components/bottom-navigation.html#specs

Changes proposed in this pull request:

  • moved flex properties to host, inherit in child anchor element
  • increased letter spacing
  • removed transforms / transitions on active tab
  • decreased badge size, add empty styles
  • fix badge positioning on both iOS and MD
  • updates e2e tests, adds a preview test for tab-bar
  • updates documentation surrounding tabs

fixes #16231
fixes ionic-team/ionic-docs#175
fixes ionic-team/ionic-docs#163

Material Design

test master tab-bar-design
preview master md preview branch md preview
scenarios branch md scenarios branch md scenarios

iOS

test master tab-bar-design
preview master ios preview branch ios preview
scenarios master ios scenarios branch ios scenarios

inherit the properties in the native anchor element

this allows the user to customize the tab-button flex properties & fixes #16231
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 16, 2018
@brandyscarney
Copy link
Member Author

This should be good to merge once checks pass. Ben approved.

@brandyscarney brandyscarney merged commit bc3e192 into master Nov 21, 2018
@brandyscarney brandyscarney deleted the tab-bar-design branch November 21, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
1 participant