Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permanent_session always enabled for dimclient #187

Open
zeromind opened this issue Jan 18, 2022 · 0 comments · May be fixed by #186
Open

permanent_session always enabled for dimclient #187

zeromind opened this issue Jan 18, 2022 · 0 comments · May be fixed by #186
Labels
bug Something isn't working

Comments

@zeromind
Copy link
Collaborator

When using dimclient DIM currently always sets the permanent_session for the Flask session.

This is due to dimclient always adding that parameter to its login requests, and DIM only checking for presence of the parameter, not its value.
Only certain values should evaluate to True, e.g. true and 1.

https://github.com/1and1/dim/blob/72db8bba0569a7d775029a99ea4498d13193c2ec/dimclient/dimclient/__init__.py#L46-L51
https://github.com/1and1/dim/blob/72db8bba0569a7d775029a99ea4498d13193c2ec/dim/dim/jsonrpc.py#L59
@zeromind zeromind linked a pull request Jan 18, 2022 that will close this issue
Draft
@zeromind zeromind added the bug Something isn't working label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow setting permanent_session to disabled zeromind/dim
1 participant
@zeromind