Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateStore Performance #317

Closed
royshum93 opened this issue Nov 8, 2017 · 3 comments
Closed

updateStore Performance #317

royshum93 opened this issue Nov 8, 2017 · 3 comments

Comments

@royshum93
Copy link
Contributor

Hi and thanks for the project.

As I have tried to build from the project, I found updateStore() method in GameEngine/Automation is particularly slow, as there are mysql query calls to in a loop. After taking the query out of the loop, the performance is hugely boosted (10X faster).
@royshum93
Copy link
Contributor Author

#318

@martinambrus
Copy link
Contributor

Hi! Thank you for the contribution, it's really appreciated :) I'll try today and will be delighted to accept the pull request if it works as advertised :)

@velhbxtyrj velhbxtyrj mentioned this issue Apr 11, 2018
Open
70 tasks
@velhbxtyrj
Copy link
Collaborator

@iopietro Pay attention to this issue. I suspect that it can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iopietro @martinambrus @royshum93 @velhbxtyrj