Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation seems stuck when the bundle has a large file #514

Closed
nisargjhaveri opened this issue May 31, 2021 · 1 comment · Fixed by #515
Closed

Installation seems stuck when the bundle has a large file #514

nisargjhaveri opened this issue May 31, 2021 · 1 comment · Fixed by #515

Comments

@nisargjhaveri
Copy link

Instalation seems stuck when the bundle has a large file. Seems like we print the progress only once for a path when installing. The issue with this is that if we have a large file in the bundle, the progress seems stuck for a long time without any feedback.

Expected behavior

Finer progress should be logged

Actual behavior.

It gets stuck without any logs for some time when a large file is being copied. After the copy, the percentage jumps by a large number suddenly.

Steps to reproduce the problem

Try installing a bundle which has one large file (few hundred MBs).

@nisargjhaveri
Copy link
Author

Seems like this is the place where we have the logic to print the log only once for a path.

if ((last_path == NULL || !CFEqual(path, last_path)) && !CFStringHasSuffix(path, CFSTR(".ipa"))) {

@nisargjhaveri nisargjhaveri changed the title Instalation seems stuck when the bundle has a large file Installation seems stuck when the bundle has a large file May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant