Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show iOS version and build version in "Device found" message #491

Merged
merged 9 commits into from
Dec 14, 2020

Conversation

dwarfland
Copy link

This is useful, e.g. for determining if a given device is eligible to run a certain project, depending on Target SDK/Deployment Target.

Copy link

@gabebear gabebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably good; but we don't change this output lightly. There is a fairly high chance this will break someone(many tools parse the non-json strings still).

I'll leave this open for awhile in case someone wants to comment and disagree.

@dwarfland
Copy link
Author

I think this is probably good; but we don't change this output lightly. There is a fairly high chance this will break someone(many tools parse the non-json strings still).

makes sense. I purposely kept this inside the (), as I figured thats the most likely change to be survived by most parsers (including my own ;).

@dwarfland
Copy link
Author

Bump?

@gabebear gabebear merged commit 00a39c8 into ios-control:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants