Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest version of docker-stacks fails #156

Open
edurenye opened this issue Dec 5, 2024 · 2 comments · May be fixed by #157
Open

The latest version of docker-stacks fails #156

edurenye opened this issue Dec 5, 2024 · 2 comments · May be fixed by #157

Comments

@edurenye
Copy link
Contributor

edurenye commented Dec 5, 2024

GPU-Jupyter Issue Report

Issue Description

Describe the issue
Since this commit was added (jupyter/docker-stacks@5365b9f) building with latest commit fails with the following error:

[+] Building 0.0s (1/1) FINISHED                                                                                                docker:default
 => [gpu-jupyter internal] load build definition from Dockerfile                                                                          0.0s
 => => transferring dockerfile: 20.19kB                                                                                                   0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG $ROOT_IMAGE results in empty or invalid base image name (line 31)                0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG $BASE_IMAGE results in empty or invalid base image name (line 189)               0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG $BASE_IMAGE results in empty or invalid base image name (line 274)               0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG $BASE_IMAGE results in empty or invalid base image name (line 329)               0.0s
 => WARN: UndefinedArgInFrom: FROM argument 'ROOT_IMAGE' is not declared (line 31)                                                        0.0s
failed to solve: base name ($ROOT_IMAGE) should not be blank

To Reproduce

./generate-Dockerfile.sh --python-only --commit latest
docker compose up --build -d

Expected Behavior
It should build without errors.

Additional Context

Just happens when you use a commit equal or newer than 5365b9f79fa4ffbb20f10133cc6ac5bec5046302

@ChristophSchranz
Copy link
Collaborator

Thanks, @edurenye, for the PR,

This is definitely a good point! The single issue that still occurs with it is, that the env variables BASE_CONTAINER and BASE_IMAGE must be set dynamically. Otherwise, the commit selection would not work for commits older than August which deprecates all versions based on Ubuntu 22 or earlier.

I'll take a closer look on it.

@ChristophSchranz
Copy link
Collaborator

This PR will be used as soon as TensorFlow supports CUDA's version 12.6.3 officially.
https://www.tensorflow.org/install/source#gpu

@ChristophSchranz ChristophSchranz pinned this issue Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants