Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Release to crates.io #869

Closed
3 of 4 tasks
eike-hass opened this issue Jun 8, 2022 · 5 comments
Closed
3 of 4 tasks

[Task] Release to crates.io #869

eike-hass opened this issue Jun 8, 2022 · 5 comments
Assignees
Labels
Chore Tedious, typically non-functional change
Milestone

Comments

@eike-hass
Copy link
Collaborator

eike-hass commented Jun 8, 2022

Description

In order to release to crates.io we need rename our packages and setup the automatic release process.

To-do list

@cycraig
Copy link
Contributor

cycraig commented Jun 10, 2022

Still need to rename packages and actually release.

@cycraig
Copy link
Contributor

cycraig commented Jun 15, 2022

I've added release = false to the examples package per the cargo-release FAQ: https://github.com/crate-ci/cargo-release/blob/c2f0d52a1c1a02cf1fdc6e68106954111f7e2c56/docs/faq.md#why-does-publishfalse-still-release

Edit: added in the Cargo.toml, not sure if we need a release.toml instead. A local cargo release dry-run did not attempt to publish examples with or without the flag, so will need testing in GitHub Actions.

Why does publish=false still release?

publish only controls whether to publish to crates.io. Some programs might want version bumping, tagging, replacements, etc without publishing.

If you do want to disable everything, set release = false.

@cycraig cycraig added the Chore Tedious, typically non-functional change label Jun 15, 2022
@cycraig
Copy link
Contributor

cycraig commented Jun 15, 2022

I don't think cargo-release was going to publish examples either way, it does distinguish release from publish specifically, and it says release in the logs:

Release
  identity-diff-derive 0.6.0
  identity-diff 0.6.0
  identity-core 0.6.0
  identity-did 0.6.0
  identity-iota-core 0.6.0
  identity-account-storage 0.6.0
  identity-credential 0.6.0
  identity-iota 0.6.0
  identity-account 0.6.0
  identity 0.6.0
  examples 0.6.0

@eike-hass
Copy link
Collaborator Author

I assume we keep release = false just to be safe, right?

@eike-hass
Copy link
Collaborator Author

Let's look at at automatic publishing separately.

Repository owner moved this from In Progress to Done in IOTA Identity - Framework Developments Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change
Projects
Development

No branches or pull requests

2 participants