-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Bech32-encoded state controller and governor addresses #1044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Would be great if you could take the time to update the test suite of IotaDID
to reflect the new behaviour of IotaDID::parse
(my bad for not covering casing when I wrote those tests).
…fix/use-bech32-addresses
…ger/identity.rs into fix/use-bech32-addresses
Description of change
Changes the address type in
IotaDocumentMetadata
frombee_block::address::Address
to a Bech32-encodedString
. This is to avoid a hard dependency onbee_block
.Also adds some missing convenience getters in the Wasm bindings.
Links to any relevant issues
Fixes
--non-default-features
failing in #1042.Type of change
How the change has been tested
Updated unit test.
Change checklist