Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bech32-encoded state controller and governor addresses #1044

Merged
merged 9 commits into from
Sep 22, 2022

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented Sep 22, 2022

Description of change

Changes the address type in IotaDocumentMetadata from bee_block::address::Address to a Bech32-encoded String. This is to avoid a hard dependency on bee_block.

Also adds some missing convenience getters in the Wasm bindings.

Links to any relevant issues

Fixes --non-default-features failing in #1042.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Updated unit test.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Sep 22, 2022
@cycraig cycraig added this to the v0.7 Features milestone Sep 22, 2022
@cycraig cycraig self-assigned this Sep 22, 2022
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Would be great if you could take the time to update the test suite of IotaDID to reflect the new behaviour of IotaDID::parse (my bad for not covering casing when I wrote those tests).

@cycraig cycraig merged commit f44a8b9 into dev Sep 22, 2022
@cycraig cycraig deleted the fix/use-bech32-addresses branch September 22, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

3 participants