Adapt StorageError to be more generic #1144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR renames and moves
StorageError
toidentity_core
so that it may be used in more contexts where the single struct error design pattern is desirable. A first example of this is the additional use inSignatureVerificationError
inidentity_jose
.Also uses
Debug + Display
as trait bounds directly on the error kind and removes theErrorKind
trait in order to reuse existing traits and not introduce too many new traits.Type of change
How the change has been tested
Runs under
cargo test
locally and the bindings build without problems.Change checklist
Add an
x
to the boxes that are relevant to your changes.