Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm bindings for KeyIdStorage #1147

Merged
merged 8 commits into from
Mar 20, 2023
Merged

Wasm bindings for KeyIdStorage #1147

merged 8 commits into from
Mar 20, 2023

Conversation

abdulmth
Copy link
Contributor

Description of change

Wasm bindings for #1134.

Links to any relevant issues

#1126

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

@abdulmth abdulmth self-assigned this Mar 19, 2023
@abdulmth abdulmth added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature labels Mar 19, 2023
olivereanderson
olivereanderson approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Added a few minor comments:

bindings/wasm/src/error.rs Outdated Show resolved Hide resolved
bindings/wasm/src/storage/key_id_storage.rs Show resolved Hide resolved
bindings/wasm/tests/key_id_storage.ts Outdated Show resolved Hide resolved
@abdulmth abdulmth merged commit 94db021 into main Mar 20, 2023
@abdulmth abdulmth deleted the feat/wasm-key-id-storage branch March 20, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivereanderson olivereanderson olivereanderson approved these changes

Assignees

@abdulmth abdulmth

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulmth @olivereanderson