Support JWT Presentations #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 17, 2023 01:23
abdulmth
added
Added
There was a problem hiding this comment.
Looks good!
Please add the missing consistency checks on the presentation unless they are somehow not necessary. I would also suggest to do the extract_dids in this PR and add a test for it. I think we should remove the old Credential, Presentation Validators and their respective APIs in the resolver in a separate PR since that seems like a bigger task than anticipated.
Co-authored-by: Philipp Gackstatter <philipp.gackstatter@iota.org>
PhilippGackstatter
approved these changes
Jun 2, 2023
identity_credential/src/validator/vc_jwt_validation/credential_jwt_validator.rs
Outdated
Show resolved
Hide resolved
identity_credential/src/validator/vp_jwt_validation/jwt_presentation_validator.rs
Outdated
Show resolved
Hide resolved
identity_credential/src/validator/vp_jwt_validation/jwt_presentation_validator.rs
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add support for issuing and validating JWT presentation.
Links to any relevant issues
#1151
(implementation does not match the issue description)
Type of change