Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method spec and JWK method type #1176

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Update the method spec and JWK method type.

  • Method spec previously incorrectly allowed for a network name to be of length 0. If present, its length must be > 0. This is already correctly checked in code. The code also allows for the presence of digits in the network name and the spec was updated to match that, too.
  • Use JsonWebKey as the method type according to Verification Method type used with VC-JWT w3c/vc-jose-cose#83, as it is the best recommendation we have for now.

Links to any relevant issues

n/a

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

None.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Documentation Improvements or additions to documentation. Excludes from changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Jun 1, 2023
@PhilippGackstatter PhilippGackstatter added this to the v0.7 Features milestone Jun 1, 2023
@PhilippGackstatter PhilippGackstatter merged commit c9ec9ba into main Jun 1, 2023
@PhilippGackstatter PhilippGackstatter deleted the chore/spec-and-method-type branch June 1, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation. Excludes from changelog Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants