-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JWT credentials for Domain Linkage #1180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
added
Enhancement
New feature or improvement to an existing feature
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
labels
Jun 9, 2023
abdulmth
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor comments, thanks for working on it.
PhilippGackstatter
added
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
and removed
Enhancement
New feature or improvement to an existing feature
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
labels
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates the domain linkage types to use JWT-based credentials.
Noteworthy changes:
test_multiple_subjects
was removed as it is not possible to create a JWT with multiple subjects since the"sub"
claim of a JWT is of type string rather than array.Issuer
type withCoreDID
on theissuer
, since the spec prescribes:Links to any relevant issues
part of #1103
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Domain Linkage tests were updated.
Change checklist
Add an
x
to the boxes that are relevant to your changes.