Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JWT credentials for Domain Linkage #1180

Merged
merged 14 commits into from
Jun 12, 2023
Merged

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Updates the domain linkage types to use JWT-based credentials.

Noteworthy changes:

  • test_multiple_subjects was removed as it is not possible to create a JWT with multiple subjects since the "sub" claim of a JWT is of type string rather than array.
  • Replace Issuer type with CoreDID on the issuer, since the spec prescribes:
    • credentialSubject.id MUST be present, and MUST be a DID.

  • Validate that origin is a domain.

Links to any relevant issues

part of #1103

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Domain Linkage tests were updated.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Enhancement New feature or improvement to an existing feature Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Jun 9, 2023
@PhilippGackstatter PhilippGackstatter added this to the v0.7 Features milestone Jun 9, 2023
Copy link
Contributor

@abdulmth abdulmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments, thanks for working on it.

identity_credential/src/credential/mod.rs Show resolved Hide resolved
bindings/wasm/examples/src/util.ts Show resolved Hide resolved
@PhilippGackstatter PhilippGackstatter merged commit 68055e2 into main Jun 12, 2023
@PhilippGackstatter PhilippGackstatter deleted the feat/jwt-domain-linkage branch June 12, 2023 11:09
@PhilippGackstatter PhilippGackstatter added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog and removed Enhancement New feature or improvement to an existing feature Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

2 participants