Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DocumentDiff to DiffMessage #511

Merged
merged 7 commits into from
Nov 29, 2021
Merged

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented Nov 27, 2021

Description of change

Rename DocumentDiff to DiffMessage which is more accurate and distinguishes it from DiffDocument.

Refactor the identity-iota project layout slightly by moving did/did and did/doc into top-level did and document modules respectively.

Fixes minor linting and formatting issues.

This PR is to reduce the number of changes in anticipation of the metadata refactor PR for #486.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tests and Wasm Nodejs examples pass locally.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added Chore Tedious, typically non-functional change Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog labels Nov 27, 2021
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cycraig cycraig merged commit 0b72612 into dev Nov 29, 2021
@cycraig cycraig deleted the chore/refactor-project-layout branch November 29, 2021 11:16
@cycraig cycraig added Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants