Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client error messages #512

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented Nov 29, 2021

Description of change

Throw a more informative DIDNotFound error message when the network of the DID does not match that of the Client when resolving it.

Removes several defunct and unused error variants from identity-iota.

Links to any relevant issues

Fixes #505

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix/chore (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tests and examples pass locally.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added the Chore Tedious, typically non-functional change label Nov 29, 2021
@cycraig cycraig merged commit 07cf8ab into dev Nov 30, 2021
@cycraig cycraig deleted the chore/improve-did-error-messages branch November 30, 2021 09:06
@cycraig cycraig added Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Improve error message when DID cannot be resolved
2 participants