Refactor Document
and ResolvedDocument
for interior mutability
#607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This refactors
WasmDocument
to useRc<RefCell>
internally to reduce clones and for interior mutability when accessed fromWasmResolvedDocument
.The
WasmDocument
API should be unchanged in terms of usage;WasmResolvedDocument
on the other hand has several breaking changes listed below.TODO
Links to any relevant issues
See discussion #603.
Type of change
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
TODO TODO
Change checklist
TODO TODO