Add Client option for retry publishing behaviour #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
added
Added
7 tasks
added 2 commits
April 24, 2022 23:01
cycraig
approved these changes
Apr 25, 2022
bindings/wasm/src/tangle/client.rs
Outdated
Comment on lines
257
to
259
|
|
||
| #[wasm_bindgen(typescript_type = "Promise<boolean>")] | ||
| pub type PromiseBoolean; |
There was a problem hiding this comment.
There is already a PromiseBool in the Wasm bindings, re-use that to avoid duplicate definitions.
There was a problem hiding this comment.
That one is located in account -> storage -> traits it didn't feel right to reuse it. It should be moved to common -> traits but that is still not merged from #815. I didn't create a file with the same name to avoid merge conflicts.
There was a problem hiding this comment.
It should be moved to common, we can deal with the merge conflicts later.
|
Pull from dev to fix CI. |
cycraig
reviewed
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add
retry_until_includedoption to theClientfor both Wasm and Rust.Add public
is_message_included(message_id) -> boolto check if message is confirmed by a milestone.Links to any relevant issues
fixes issue #811
Type of change