Add BaseEncoding
to replace encode_b58
, decode_b58
, encode_multibase
, decode_multibase
#870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Replaces the
encode_*
anddecode_*
utility functions with a newBaseEncoding
interface with static methods. This allows us to remove several dependencies forbs58
andhex
encodings.Note: this does not affect the Wasm bindings, since we did not export the base encoding utility functions anyway, should we?
Added
BaseEncoding
.BaseEncoding::encode
.BaseEncoding::decode
.BaseEncoding::encode_base58
.BaseEncoding::decode_base58
.BaseEncoding::encode_multibase
.BaseEncoding::decode_multibase
.Removed
encode_b58
.decode_b58
.encode_multibase
.decode_multibase
.Type of change
How the change has been tested
Added unit tests, existing tests all pass.
Change checklist