Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): improve and test encoding of KIND #816

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Oct 20, 2022

Linked Issues

None

Notes to Reviewer

As a reviewer, please pay particular attention to the following areas when reviewing this PR and tick the above boxes after you have completed the steps.

Test cases

  • Review and run tests that were added/changed.
  • Suggest places that may benefit from test cases.

Copy link
Collaborator

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much improvement, very wow

@grtlr grtlr merged commit 9c1b2b3 into main Oct 20, 2022
@grtlr grtlr deleted the feat/types/kind-query branch October 20, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants