Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail tests early when "storage" not enabled #1563

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Fail tests early when "storage" not enabled #1563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
abdaa95
Clarify the need to run tests with "storage" feature enabled
Nov 3, 2023
a22aff7
Put WalletOptions::with_storage_path behind the feature flag
Nov 3, 2023
98491eb
Merge branch '2.0' into fail-tests-early
thibault-martinez Nov 22, 2023
e100798
Feature gate tests
thibault-martinez Nov 22, 2023
58dc89b
Revert README changes
thibault-martinez Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bindings/core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ impl WalletOptions {
self
}

#[cfg(feature = "storage")]
pub fn with_storage_path(mut self, storage_path: impl Into<Option<String>>) -> Self {
self.storage_path = storage_path.into();
self
Expand Down
3 changes: 3 additions & 0 deletions bindings/core/tests/combined.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ use iota_sdk_bindings_core::{
};
use pretty_assertions::assert_eq;

#[cfg(feature = "storage")]
#[tokio::test]
async fn create_wallet() -> Result<()> {
let storage_path = "test-storage/create_wallet";
Expand Down Expand Up @@ -59,6 +60,7 @@ async fn create_wallet() -> Result<()> {
Ok(())
}

#[cfg(feature = "storage")]
#[tokio::test]
async fn client_from_wallet() -> Result<()> {
let storage_path = "test-storage/client_from_wallet";
Expand Down Expand Up @@ -100,6 +102,7 @@ async fn client_from_wallet() -> Result<()> {
}

// TODO reenable
// #[cfg(feature = "storage")]
// #[tokio::test]
// async fn build_and_sign_block() -> Result<()> {
// let storage_path = "test-storage/build_and_sign_block";
Expand Down